-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving AWS partition detection #801
base: main
Are you sure you want to change the base?
Conversation
Hi Nitrino - thanks for the PR! Just to help me understand, what's the issue with using OOS? Is there some module to support it that plugs into ex_aws or something? Might this still be a problem if OOS ended up using a region name which matched one of AWS's? |
Hi @bernardd Yes, in the future there may be a problem if Oracle adds the same name of the region as the AWS. In this case, it will be better to keep the accurate list of AWS regions or add setting the control of this logic. Full list Oracle regions: https://docs.oracle.com/en-us/iaas/Content/General/Concepts/regions.htm |
Hey - sorry for not getting back to you sooner. Thinking about this, I wonder if a better approach might not be some config parameter that allows us to skip the check entirely. Something like |
Hey @bernardd At the moment, I do not know of compatible systems with same regions, but I think the config will still be a more correct solution. |
Bumps [jason](https://github.com/michalmuskala/jason) from 1.2.2 to 1.3.0. - [Release notes](https://github.com/michalmuskala/jason/releases) - [Changelog](https://github.com/michalmuskala/jason/blob/master/CHANGELOG.md) - [Commits](michalmuskala/jason@v1.2.2...v1.3.0) --- updated-dependencies: - dependency-name: jason dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bump jason from 1.2.2 to 1.3.0
I am trying to use
ex_aws
with Oracle Objects Storage and I receive an errors3 not supported in region us-sanjose-1 for partition aws
. This happens due to the same region formats for AWS and Oracle.Example:
us-sanjose-1
matches the given regular expressionex_aws/lib/ex_aws/config/defaults.ex
Line 80 in 56392c1
This PR improves AWS region detection logic by clarifying the second part of the region name.
I also added support for the
me
zone forme-south-1
Middle East (Bahrain) region